Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify creation of links to entity pages #25254

Merged

Conversation

OmarHawk
Copy link
Contributor

@OmarHawk OmarHawk commented Feb 19, 2024

so that everywhere entityPage is being used as attribute

I noticed that the only place where the links to entity pages are being created differently is in the entity detail page. Everywhere else (e.g. list view), entityPage is already being used.

So this change improves consistency in the code base and also makes it easier for e.g. Blueprints to change something here consistently (that's why I came here ;-))


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

so that everywhere entityPage is being used as attribute
@mshima mshima merged commit bf210eb into jhipster:main Feb 19, 2024
39 checks passed
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants