Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer project scoped node/npm binaries over global binaries #14315

Merged
merged 2 commits into from
May 19, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Mar 14, 2021

Closes #14249


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Should we merge it?

@DanielFran
Copy link
Member

@mshima is it OK to merge?

@mshima
Copy link
Member Author

mshima commented May 19, 2021

IMO yes.

Worth noting:

cc @atomfrede

@atomfrede
Copy link
Member

Good to know. Nevertheless let's merge it.

@atomfrede atomfrede merged commit 2ca90dd into jhipster:main May 19, 2021
@mshima
Copy link
Member Author

mshima commented May 19, 2021

The failures seems related to npm/cli#2715.

@atomfrede
Copy link
Member

atomfrede commented May 19, 2021

So related to #14934. Should we add --no-audit to maven/gradle execution until its fixed upstream?

@mshima mshima mentioned this pull request May 25, 2021
6 tasks
@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
@mshima mshima mentioned this pull request Jun 17, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer project scoped node/npm binaries over global binaries
4 participants