Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openapi gen cli improvements #11130

Merged
merged 12 commits into from
Feb 12, 2020
Merged

Openapi gen cli improvements #11130

merged 12 commits into from
Feb 12, 2020

Conversation

ecostanzi
Copy link
Contributor

@ecostanzi ecostanzi commented Jan 16, 2020

Fix #10510 .

  1. add openapi generator cli command to npm scripts
  2. update to openapi-generator-cli 1.0.8-4.2.2
  3. feign client configuration excluded via FilterType.REGEX

@avdev4j
Copy link
Contributor

avdev4j commented Jan 20, 2020

hi @ecostanzi,
great job !
I would like to review this PR, I hope tomorrow or this weeks during lunch time. Stay tuned ;)

@DanielFran
Copy link
Member

@avdev4j @cbornet Did you have time to review it?

@avdev4j
Copy link
Contributor

avdev4j commented Feb 11, 2020

LGTM

Tested with both old and new version. The improvements are great. Remove the ExcludeComponentScan for using filter and avoid to call the openapi jar.

I suggest to merge this PR now and do another PR to upgrade the openapi generator later if we don't have enough time now.

This PR has been open for too long (my fault) ;)

@DanielFran
Copy link
Member

@ecostanzi Are you expecting to update the generator version soon or can this be merged?

@ecostanzi
Copy link
Contributor Author

@DanielFran yes I'll do it before merge

@DanielFran
Copy link
Member

Thanks @ecostanzi

@DanielFran DanielFran merged commit 44b62ab into jhipster:master Feb 12, 2020
@pascalgrimaud pascalgrimaud added this to the 6.7.1 milestone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve openapi-client sub-generator
7 participants