Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get with 3 arguments: (url, options, callback) #116

Open
flaviotordini opened this issue Aug 22, 2020 · 1 comment
Open

get with 3 arguments: (url, options, callback) #116

flaviotordini opened this issue Aug 22, 2020 · 1 comment

Comments

@flaviotordini
Copy link

flaviotordini commented Aug 22, 2020

Hello, I'm trying to browserify a library that contains code like this:

const request = HTTP.get(ref, options, resp => {
// stuff
});
The call results in an error because stream-http does not implement this function with 3 arguments.
I'm testing with browserify version 16.5.2

I checked and the method actually exists in NodeJS:
https://nodejs.org/api/https.html#https_https_get_url_options_callback

I'm new to this technology so I could be missing something obvious...

@jhiesey
Copy link
Owner

jhiesey commented Aug 23, 2020

Hi @flaviotordini! I apologize, I haven't done much maintenance on stream-http recently, so it is compatible with a quite old version of the node http API. Pull requests welcome! I do intend to fix this at some point though.

Related to #74

Istador added a commit to Istador/pine-interactive-map that referenced this issue Feb 13, 2021
`webpack` v4 => v5:
- `script-ext-html-webpack-plugin` is deprecated and unnecessary now,
the feature I use is now in `html-webpack-plugin`
- `preload-webpack-plugin` is deprecated, use fork
`@vue/preload-webpack-plugin` instead
- `optimize-css-assets-webpack-plugin` wont adjust to `webpack` v5, use
`css-minimizer-webpack-plugin` instead

`leaflet` 1.6.0 => 1.7.1:
- contains my fix for Leaflet/Leaflet#6764
now, so I can remove my workaround.

`sass`:
- `node-sass` is deprecated, use `sass` (`dart-sass`) instead.
- `sass-loader`: the `~` import no longer works. Therefore prefix
spritesmith filenames with `img-`, to fix the ambiguity between
`src/css/icons.scss` and `build/img/icons.scss`

Can't upgrade `wtf_wikipedia` to 8.0.0 or higher right now, because of
issues with:
- https://github.com/substack/https-browserify/issues/9
- jhiesey/stream-http#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants