Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to NO_COLOR #7

Closed
twpayne opened this issue Sep 21, 2020 · 4 comments · Fixed by #12
Closed

Add reference to NO_COLOR #7

twpayne opened this issue Sep 21, 2020 · 4 comments · Fixed by #12

Comments

@twpayne
Copy link

twpayne commented Sep 21, 2020

https://no-color.org/ has different, but related, goals. Maybe add a link or description to README.md about how the two are related?

@jhasse
Copy link
Owner

jhasse commented Sep 21, 2020

IMHO it would even make more sense to merge the two projects, see https://github.com/jcs/no_color/issues/28.

@jonasbn
Copy link

jonasbn commented May 26, 2021

The Rust crate colored support both NO_COLOR and CLICOLOR (and CLICOLOR_FORCE). The documentation however lacks a clarification on how the two standards interact, so I did some basic testing.

My conclusion was that in the colored implementation the two can live side by side, the precedence is as follows:

  1. CLICOLOR_FORCE
  2. NO_COLOR
  3. CLICOLOR

I have created a PR with colored, which has not been merged yet.

Perhaps you could outline/document your recommendations on this topic from the perspective of your standard. I think the implementation in colored makes sense.

@HorlogeSkynet
Copy link

My conclusion was that in the colored implementation the two can live side by side, the precedence is as follows:

1. `CLICOLOR_FORCE`
2. `NO_COLOR`
3. `CLICOLOR`

Exactly what I ended up implementing too @jonasbn, see my comment on jcs/no_color#28. Cheers

@twpayne
Copy link
Author

twpayne commented Jan 31, 2022

No response from the repo owner in over a year, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants