Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor prefixes from sass #3931

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jnoordsij
Copy link

@jnoordsij jnoordsij commented Oct 30, 2024

This is a new feature | improvement | bugfix | documentation fix.

Proposed solution

When debugging some other issues with placeholders in my application, I noticed some vendor prefixes popping up on attributes where I did not expect them. Then I figured that they are actually hardcoded within the scope of this repository, rather than applied by tooling (e.g. autoprefixer).

Edit: for the ::placeholder mixin, it was actually rendering all the variants except for the correct modern ::placeholder pseudo-element, so this actually might ensure proper behavior across environments that previously did not work.

This PR removes the hardcoded vendor-prefixed variants of some properties. The preferred way (I think) should be using tooling to handle this. Although the README mentions that autoprefixer is used within this repository, it seems it has since been replaced with cssnano, which may not include it by default.

Probably this requires rebuilding css too, however the npm run build alias mentioned in CONTRIBUTING.md no longer exists, so I'm not sure which parts are intended to run on MR submissions.

Note: I encountered this issue on version v0.9.4, but I'm not sure if bugfixes are still welcome for the old version?

Tradeoffs

Theoretically this could cause a change of behavior on legacy browsers. Given the wide availability of the non-prefixed alternatives and the fact that tooling like autoprefixer is commonly used, I suspect this will have little to no impact in that regard.

Testing Done

None.

Changelog updated?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant