Fix error in Conda environments that use Python 3.10 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgosmann
approved these changes
Jun 12, 2023
| @@ -94,7 +98,7 @@ def activate_venv(venv): | |||
| raise IncompatibleVenvError( | |||
| f"The virtual environment {venv!r} has multiple lib/pythonX.Y directories." | |||
| ) | |||
| site_packages = os.path.join(lib_dir, python_dirs[0], "site-packages") | |||
| site_packages = os.path.join(list(python_dirs)[0], "site-packages") | |||
There was a problem hiding this comment.
non-critical/very minor:
Suggested change
| site_packages = os.path.join(list(python_dirs)[0], "site-packages") | |
| site_packages = os.path.join(next(python_dirs), "site-packages") |
might be slightly more efficient as it avoids creating a new list.
|
Released as version 3.0.2. |
|
@jgosmann, thanks for the quick review and releasing a new version for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this great package! We're using it in Spyder to easily run Pylint in any virtual or conda environment.
This PR will solve an error discovered by our users in Python 3.10 conda envs for Posix systems. It seems in that case conda automatically creates a symlink called
python3.1, which points to thepython3.10directory. To avoid it, I resolved all symlinks for Python directories found bypylint_envand discarded the repeated ones.