Skip to content

compass(kv): state whole_number union case in two lines under Limits #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgong5 merged 1 commit into from
Sep 24, 2026
Merged

compass(kv): state whole_number union case in two lines under Limits #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions atom/compass/kv/handoff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,8 @@ def whole_number(field: str, value: Any) -> int:
accepted changes on the way to the `int` returned, and that check is what
refuses integer text: `int("8")` is 8, which is not equal to "8".

Limits: the dtype text test also refuses a whole number whose dtype text
has "bool", such as a 0-d array of a numpy union dtype with a field
"is_bool", and the message then says it is not a whole number. An
Limits: a whole number whose dtype text has "bool", such as a 0-d array
of a numpy union dtype with a field "is_bool", is refused as not one. An
exception from the value, from its dtype, or from an object either of them
returns, such as the result of `__ne__`, can escape as raised, not as this
refusal, and an `AttributeError` from reading `dtype` counts as no dtype.
Expand Down