compass(docs): pin the CPU gate readings in scripts/compass/README.md to their commits, and 08/16 leftovers - #351
Conversation
…o their commits; fix 08:34, 08:39, 16:126 scripts/compass/README.md: the 4030 row names 105ca41 (PR #6's gate table), its clock is the six runs at d737f15 and 7ff80cc recorded in 8c0ee37, and the 3956 half says its control had PR #6's scripts/compass/ copied in. The readings paragraph pins 3925 at 83daf63, 4005 at 3afcb48, 4022 at 71d2a1a and 4030 at 105ca41, and drops 3988, which no record ties to a commit. 08: the plugin collection no longer attaches one time to two commits, and the floor counts the 2 tier files that reach rocminfo alone (34). 16: two sentences that both said the 3956 had no tests/compass are one. Closes #350 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
test_prefill_prefix_vs_native.py measured at cb68428 in xiaobizh_n18 on node 18, HIP_VISIBLE_DEVICES=3 (card 3 holding 0.3 GB before the run): 4 passed in 8.67s, rc=0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Review cycle 1 — PR #351 (issue #350), head Agent-authored review. I read the eight Design principles in Verdict: APPROVE Citations checked (principle 8: "Every claim carries its measurement")
The
|
… 19 of the flake table's 21 runs (#354) (#356) 08:51 gave one time, 0.78s, for two files run alone. It came in with 4c16792 (#6), the only commit git log -S finds for it, and that commit states no per-file figure, so there is nothing to split. The time is dropped, as #351 did at 08:34. The outcome, the rc and the commit stay. The flake-rate paragraph in scripts/compass/README.md said "one branch". #93, the brief #99 copied it from, names no commit either. PR #79's review (issue comment 5765186351) records 19 runs at b58a48c (7 gate + 12 direct): 17 nominal, 1 skip-variant (4476 / 150) and the 1.89x hard failure. The paragraph now names that commit for those 19 and says the other 2 name none. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Closes #350
Pins the CPU gate readings in
scripts/compass/README.mdto their commits, following #350's body and its last comment (the #349 review's N1 and inline r4087445424, r4087445580, r4087445720). It also fixes08:34,08:39,08:65and16:126-129. The wording mirrors #349 (cb684287f).Change: 3 files, +17 / −16 (README +9/−8,
08+5/−4,16+3/−4). Production lines 0, test lines 0. The brief estimated 10-20.Dev record
105ca4197, PR compass: worktree discipline, two-tier gate scripts and GPU pre-flight (P0.1) #6's head, which landed as4c16792d9(same treefbcb03674). The clock is the six runs atd737f15e7and7ff80cc4brecorded in8c0ee374f, not compass: worktree discipline, two-tier gate scripts and GPU pre-flight (P0.1) #6's "seventeen runs across ten commits", which no record lists. "commit not recorded" and "identical in every run on 2026-09-21" are gone. The 3956 half says its control had PR compass: worktree discipline, two-tier gate scripts and GPU pre-flight (P0.1) #6'sscripts/compass/copied in.83daf636d, 4005 at3afcb4880, 4022 at71d2a1ac2and 4030 at105ca4197, and 3956 = 3925 + 31 is stated. 3988 is dropped. It first appears in3afcb4880'sgate_cpu.shasBaseline is 3988 passed, 0 failed at 29, which names no commit.b78e0bc97,71197264eandf3f584ea4repeat it without one. A search of issues and PRs finds it only in snapshot.sh refuses with exit 92 on a bare archive, and blames the wrong thing #68, fix(compass): resolve the integration ref, and name the step that refused (#68) #82, compass(docs): stop restating the CPU gate census in 08, and pin scripts/compass/README.md:14 to a commit #345 and compass(docs): scripts/compass/README.md still says the 4030 row has no commit, and lists 3925 / 4022 unpinned #350, all of which quote the paragraph.08:34. The time is dropped. One1.45swas attached to runs at two commits, and it is noise: I read 1.41 s atfada7424e, the same as the compass(docs): pin 16's first CPU-tier census and 08's Revised paragraph to their commits #349 reviewer.08:32/08:39. The floor is now 34, not 32: 29 + the 2 tier files that reachrocminfowhen run alone + 3. I re-measured both tier files atfada7424e.08:65. "4 passed in the GPU container" is pinned tocb684287f. I measured it myself (below).16:126-129. The two sentences are merged into one that also names the control's copiedscripts/compass/: −1 line net.9120a96a3(whosegate_cpu.shalso prints "Baseline at 83daf63 is 3925") is not on GitHub (GET commits/9120a96a3gives 422), so it is not cited.9c8df1328is.Citations
105ca4197GET pulls/6:head.sha=105ca4197…,merged=true,merge_commit_sha=4c16792d9….rev-parse ^{tree}givesfbcb03674for both. #6's "Gates" table has 4030 / 0 / 149 / 3 andGATE_CPU_RC0 in the branch columnscripts/compass/copied in042aad97dfork/feature/atomcompass_newat042aad97dwith onlyscripts/compass/copied in". The control column reads 3956 / 0 / 149 / 3, rc 0.git ls-tree 042aad97d scripts/shows noscripts/compassd737f15e7and7ff80cc4b8c0ee374f8c0ee374fis an ancestor of105ca4197. Neither run commit is, because they predate the restack. All three resolve on the fork (GET commits/<sha>)tests/compass83daf636d9c8df1328(onfork/compass/p0.2-baselines, parent83daf636d): "Measured at 83daf63 on node 18 … a 125-file CPU gate … 3925 passed, 0 failed". At83daf636d,ls-treegives 187 test files, 30 intests/plugin, and nothing undertests/compass: 157 − 32 = 12583daf636d→042aad97dgit diff --stat 83daf636d 042aad97d -- testsis empty.cpu_gate_exclude.txtateb1d6d4fa(32 entries, P0.1's first cut) against105ca4197(29) differs by exactlytest_dp_metadata.py,test_dp_sync_layout.pyandtest_forward_mode.py. I measured those three at83daf636dinxiaobizh_n18_cpu:31 passed in 0.23s, rc=0tests/compassat 493afcb4880b78e0bc97: "CPU row is the measured 4005 with its 3956 ATOM + 49 tests/compass decomposition … at 3afcb48 on node 18". At3afcb4880: 1tests/compassfile, 13 triggers, 29 exclusionstests/compassat 6671d2a1ac2236abfd9a(parent71d2a1ac2) writes the trigger header "Measured at 71d2a1a… 188 files = 30 + 29 + 129 … 4022 passed + 128 skipped + 3 xfailed", and5ca21de2bremoves it.f3f584ea4, an ancestor of71d2a1ac2, says "4005 -> 4022 (3956 + 66)". At71d2a1ac2: 188 / 30 / 29 exclusions, 1tests/compassfile, 30 triggers (+17 over 13)153 tests collected, 7 errors, rc=2fada7424exiaobizh_n18_cpu: rc=2,153 tests collected, 7 errors in 1.41srocminfoalonefada7424etest_postprocess_width.pyrc=2,1 error in 0.82s;test_v4_checkpoint_slot_copy.pyrc=2,1 error in 0.88s; bothGet GPU arch from rocminfo failed. Neither is infada7424e'scpu_gate_exclude.txttest_prefill_prefix_vs_native.py: 4 passed in the GPU containercb684287f08:65: GPU measurementxiaobizh_n18on node 18, 2026-09-24. I staged agit archiveofcb684287finto/tmp/i350gates/tip/ATOM, and the tar md5 matched at both ends.atom.__file__=/tmp/i350gates/tip/ATOM/atom/__init__.py, which I asserted before the run.Card:
HIP_VISIBLE_DEVICES=3. I chose it withrocm-smi --showmeminfo vram(card 3 held 298 MB). Cards 0 and 1 held about 171 GB each at 0% use.torch
2.10.0+rocm7.2.4.git3d3aa833, hip7.2.53211. The run was undertimeout -k 10 900, unpiped:Named result
grep -n "commit not recorded" scripts/compass/README.mdfinds nothing (rc=1).83daf636d, 3956 →042aad97d, 4005 →3afcb4880, 4022 →71d2a1ac2, 4030 →105ca4197; 4380 →68ef4f329and 4501 →186d12829were already pinned. L64'sBaseline is 4030 passedis the output of105ca4197's owngate_cpu.sh, named at L30.08and16names its commit.Gate 1: CPU tier, delta against a measured control
Node 18,
xiaobizh_n18_cpu, 2026-09-24, load average about 17-20 with other tenants' gates running.git archivewith stamps, staged withdocker exec -i … tar -xinto/tmp/i350gates/{ctl,br}/ATOM. The tar md5 matched at both ends.git commit-tree 5dc3962ab -p cb684287f -p 3d504c255=bbb9eefeb. No ref was created.atom.__file__was asserted under each root before the run.scripts/compass/gate_cpu.sh --junitxml=…undertimeout -k 10 2400, sequentially and unpiped.cb684287f(tip)5dc3962ab)commit: cb684287f (stamp)commit: bbb9eefeb (stamp)gpu:GATE_CPU_RCTestTheRegionIsNotCopiedPerChunk,TestNoSizeAtWhichACallStopsBeingOne::…[minimax]andtest_gc_utils.py::test_freezing_twice_is_additive_and_harmless.git merge-tree --write-tree cb684287f 3d504c255=5dc3962ab4ee27b41f1f2b08604584567072e80b. That equals3d504c255^{tree}, and the tip was read again just before this was written.Gate 2 does not apply, because the change is docs only. Gate 4 is the coordinator's reviewer.
🤖 Generated with Claude Code