Use custom point light preparation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While GpuArrayBuffer does a lot of this for us, it also has a quirk where it won't write to the GPU if the array is empty, which messes with our pipeline.
jgayfer
added a commit
that referenced
this pull request
Jul 28, 2024
* Revert "Use custom point light preparation (#17)" This reverts commit 2ae0336. * Write "empty" point light to render world GpuArrayBuffer won't write to the GPU if we have no point lights (an empty array). We first tried writing a more custom integration with the GPU, but ended up running into a very similar problem. For now lets use GPUArrayBuffer and all it does for us, writing an "empty" point light to ensure we'll always have a binding. * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While
GpuArrayBufferdoes a lot of this for us, it also has a quirk where it won't write to the GPU if the array is empty, which messes with our pipeline.Fixes #16