This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Cleaned up namespace imports to reduce symbol collisions #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
concept ACK -- looks like we need to fix up the travis build before we can accept, though (You didn't break it up, but it must be fixed before merging) |
|
See #45 for the fix |
|
Thanks for the fix! I wasn't sure if this check was safe to remove or had to be modified moving forward. |
laanwj
added a commit
to bitcoin-core/univalue-subtree
that referenced
this pull request
Aug 31, 2018
d208f98 Cleaned up namespace imports to reduce symbol collisions (Jason B. Cox) Pull request description: Exact commit taken from jgarzik#46 by jasonbcox Tree-SHA512: 127db323530b03147d52de4107600024921f69756e0b2f0ecbb59f27f1783758a4d9016eb3b52c64170d03aa496c8b682affee171c51f86a4a4af6907b004b94
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove namespace imports as they pollute namespace and are prone to symbol clashes.