This repository has been archived by the owner on Feb 15, 2024. It is now read-only.
Add doxygen support, all ready just need good comments now #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good progress :) |
jgarzik
reviewed
May 10, 2017
lib/univalue.cpp
Outdated
| for (std::map<std::string,UniValue::VType>::const_iterator it = t.begin(); | ||
| it != t.end(); ++it) { | ||
| size_t idx = 0; |
There was a problem hiding this comment.
Comments:
-
Please put into a separate pull request, as this is unrelated to documentation changes.
-
Let the compiler perform the hoisting. No need to do it manually.
General rule: Limit scope of a variable, and let the compiler figure out the rest. If it becomes a performance issue notable on profiles, revisit.
jgarzik
reviewed
May 10, 2017
lib/univalue.cpp
Outdated
| @@ -163,6 +163,9 @@ bool UniValue::findKey(const std::string& key, size_t& retIdx) const | |||
|
|
|||
| bool UniValue::checkObject(const std::map<std::string,UniValue::VType>& t) | |||
| { | |||
| if (typ != VOBJ) | |||
| return false; | |||
|
|
|||
| size_t idx = 0; | |||
There was a problem hiding this comment.
Agree with this change - but please do it outside the doxygen pull request. Thanks!
jgarzik
added a commit
that referenced
this pull request
Aug 3, 2017
pushKV: Behave properly in the face of duplicate keys. checkObject: return error, if not object. Inspired-by: Charles Yin <[email protected]> in PR #37
|
Merged a modified version of your unrelated-to-doxygen changes as ceb1194 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.