Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count filters in addition to variables #91

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

brian-vanderford
Copy link
Contributor

Makes Template.analyze and friends count filters in addition to variables.

Copy link
Owner

@jg-rp jg-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brian-vanderford,

Looks good. Would counting tags be a useful feature too?

tests/test_analyze_template.py Show resolved Hide resolved
tests/test_contextual_analysis.py Show resolved Hide resolved
@brian-vanderford
Copy link
Contributor Author

Looks good. Would counting tags be a useful feature too?

It didn't occur to me, but I could see the same use case as with filters; you can't render the template, but you'd still like to tell your users when they're trying to use a tag that won't be defined when it does get rendered.

@jg-rp jg-rp merged commit 2441043 into jg-rp:main Dec 20, 2022
@brian-vanderford brian-vanderford deleted the analyze-filters branch December 20, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants