Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress indicator to run-seedbox.sh #66

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

tblaudez
Copy link

@tblaudez tblaudez commented Nov 29, 2024

Add a progress indicator to the configuration loop in run-seedbox.sh
I added this to avoid frustration when running the script is lengthy (especially when my VPS in under heavy load).

The JSON configuration is put in a variable casted a as Bash array so that we can still loop over it AND retrieve its length.
Another variable is added to count the current iteration of the loop.

Using this information, we use printf to add a new output line with constant width that indicates the current progress.
This line is being constantly overwritten by each iteration thanks to the carriage return and the constant width.
When we are on the last iteration of the loop; we break out of the progress line by adding a sole newline.

Cette fois c'est une vraie PR mdr

Copy link

gitguardian bot commented Nov 29, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
878723 Triggered Generic Password 3bb3662 .env.sample View secret
878724 Triggered Generic Password 3bb3662 .env.sample View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@tblaudez tblaudez changed the base branch from dev to master November 29, 2024 10:18
@tblaudez
Copy link
Author

Edit: Changed base from dev to master since I edited from this branch

@jfroment
Copy link
Owner

Could you please target dev instead of master so the changes here will be part of next release?
I try to keep the master branch tied to releases so newcomers or people who want stability have all tested/validated/documented changes only in master. No problem if the change originates from master as they are no breaking changes.

@jfroment jfroment changed the base branch from master to dev November 29, 2024 14:09
@jfroment
Copy link
Owner

Actually I can target dev myself :)

@tblaudez
Copy link
Author

Sure thing ! I'll keep it in mind for the next PRs and use dev as the source branch.

@tblaudez
Copy link
Author

tblaudez commented Dec 6, 2024

I noticed the progress bar was breaking visuals when debug mode is active, so I added a condition to disable it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants