-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress indicator to run-seedbox.sh #66
base: dev
Are you sure you want to change the base?
Conversation
v2.1 - The Pearl ⚪
v2.2 - The Flame 🔥
v2.2.2 - The tiny Flame 🔥
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
878723 | Triggered | Generic Password | 3bb3662 | .env.sample | View secret |
878724 | Triggered | Generic Password | 3bb3662 | .env.sample | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Edit: Changed base from dev to master since I edited from this branch |
Could you please target |
Actually I can target |
Sure thing ! I'll keep it in mind for the next PRs and use dev as the source branch. |
I noticed the progress bar was breaking visuals when debug mode is active, so I added a condition to disable it |
Add a progress indicator to the configuration loop in run-seedbox.sh
I added this to avoid frustration when running the script is lengthy (especially when my VPS in under heavy load).
The JSON configuration is put in a variable casted a as Bash array so that we can still loop over it AND retrieve its length.
Another variable is added to count the current iteration of the loop.
Using this information, we use printf to add a new output line with constant width that indicates the current progress.
This line is being constantly overwritten by each iteration thanks to the carriage return and the constant width.
When we are on the last iteration of the loop; we break out of the progress line by adding a sole newline.