Reduce package size by adding "files" field to package.json#65
Merged
jonkoops merged 2 commits intojfromaniello:mainfrom Mar 23, 2022
Merged
Reduce package size by adding "files" field to package.json#65jonkoops merged 2 commits intojfromaniello:mainfrom
jonkoops merged 2 commits intojfromaniello:mainfrom
Conversation
Collaborator
|
Great addition, thanks for your contribution @FujiHaruka! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I greatly appreciate this great and simple library you developed to join URLs.
Because your library is so famous and so many installed, it would be nice if the package size gets smaller.
This PR just suggests to reduce the package size by adding "files" field to package.json
This change will make the package size smaller.
I checked how effective it is by comparing the sizes as following.
Without "files" field: 18.3 kB
With "files" field: 4.8 kB
Thank you.