Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Extended value for SARIF record #220

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Get Extended value for SARIF record #220

merged 8 commits into from
Nov 4, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Nov 4, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Depends on:

When recording SARIF output, the ExtendedSummary value was not injected by core.
This PR remediate this issue

@attiasas attiasas added the bug Something isn't working label Nov 4, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas merged commit ebfda25 into jfrog:dev Nov 4, 2024
9 checks passed
@attiasas attiasas deleted the fix_extended_on_sarif_record branch November 4, 2024 10:48
@BrewTestBot BrewTestBot mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranturgeman eranturgeman eranturgeman approved these changes

@orz25 orz25 Awaiting requested review from orz25

@hadarshjfrog hadarshjfrog Awaiting requested review from hadarshjfrog

@orto17 orto17 Awaiting requested review from orto17

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiasas @eranturgeman