Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven Core artifacts should be in provided scoped #83

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Maven Core artifacts should be in provided scoped #83

merged 1 commit into from
Oct 18, 2023

Conversation

slawekjaranowski
Copy link
Contributor

Fix #70

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@slawekjaranowski
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@slawekjaranowski
Copy link
Contributor Author

@yahavi , @Or-Geva - can you look?

@yahavi yahavi added the bug Something isn't working label Oct 18, 2023
yahavi
yahavi approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this contribution @slawekjaranowski!

@yahavi yahavi changed the title Maven Core artifacts in provided scoped Maven Core artifacts should be in provided scoped Oct 18, 2023
@yahavi yahavi merged commit 8bb59aa into jfrog:master Oct 18, 2023
4 checks passed
@slawekjaranowski slawekjaranowski deleted the fix-70 branch October 18, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should be compatible with the upcoming 4.x Maven release
2 participants
@slawekjaranowski @yahavi