Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination disappearing #27

Closed
denro2 opened this issue Oct 14, 2021 · 5 comments
Closed

Destination disappearing #27

denro2 opened this issue Oct 14, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@denro2
Copy link

denro2 commented Oct 14, 2021

Describe the bug
When using the device to show National Rail services the destinations dissapear from the screen once the calling at animations have run

To Reproduce
Steps to reproduce the behaviour:
Upon startup of Raspberry Pi
Have tried several different stations with the same behaviour seen

Expected behaviour
Destination name should remain visible for each train service

Screenshots or Error Trace
If applicable, add screenshots to help explain your problem.

Program information:

  • Pi Type - Pi Zero WH
  • Program - NationalRail.py
  • Version - 2.6.NR

Additional context
Add any other context about the problem here
Tra.zip
.

@denro2 denro2 added the bug Something isn't working label Oct 14, 2021
@denro2
Copy link
Author

denro2 commented Oct 15, 2021

startupDisplay
For information here is the relevant startupDisplay.sh file.

I have tried various setups, with and without reduced animations and with varying speeds and number of cards. However, the destination always disappears after the first "calling at" animation. Even with reduced animations they disappear after some seconds.

@jfoot
Copy link
Owner

jfoot commented Oct 15, 2021

Hi @denro2 thanks for the bug report, I'll have a look into this soon, I'll need to reset up my dev environment on my new device, so please give me a bit of time and I'll get back to you soon :)

@jfoot
Copy link
Owner

jfoot commented Dec 28, 2021

Hi @denro2, I'm very sorry it took so long for me to look into this for you and thank you for your patience! This turned out to be a rather strange issue, on my emulator (and where I do all my development) I couldn't reproduce the issue, then even when using real hardware I could only reproduce it some of the time. In the end it looks like I was simply measuring the wrong thing and as such drawing the destination off screen; so a relatively simple fix, I'm just not sure why it wasn't reproducible on my emulator though.

I've already pushed the edits onto Master, so you're display should automatically update if left on for 24hrs, or you can force it to update by doing a git pull. Although, I'm going to do some more in-depth testing tomorrow before officially marking this issue as closed.

Once again, I'm really sorry about the time it took, been very busy with uni work these past few months :(

@jfoot
Copy link
Owner

jfoot commented Dec 28, 2021

I've now tested this and I am confident it seems to have resolved the issue, so shall be closing the issue. But please do let me know if you experience any other issues. Thanks, Jonathan.

@jfoot jfoot closed this as completed Dec 28, 2021
@denro2
Copy link
Author

denro2 commented Dec 28, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants