Skip to content

Commit

Permalink
Disable writing parsetab files to disk.
Browse files Browse the repository at this point in the history
This fixes mailgun#206.

Before this change, when multiple Python processes are simultaneously
doing a `from flanker.addresslib import address`, it's possible for some
of them to crash in `ply` code.

See dabeaz/ply#184, where
I attempted to work around this issue by changing ply. You can see in this comment: dabeaz/ply#184 (comment) that the author of ply suggests to workarounds for this issue:

1. Remove `ply` as a dependency in setup.py and copy the source code of `ply` into `flanker`.
2. Disable writing parsetab files to disk when invoking `yacc`.

2) seemed like the simpler solution to me, so that's what I've done
here.
  • Loading branch information
jfly committed Sep 30, 2018
1 parent 28d7680 commit 4f63fc2
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 455 deletions.
90 changes: 0 additions & 90 deletions flanker/addresslib/_parser/addr_spec_parsetab.py

This file was deleted.

Loading

0 comments on commit 4f63fc2

Please sign in to comment.