Merge main into linting branch#71
Merged
sstendahl merged 40 commits intolinting_testfrom Aug 31, 2023
Merged
Conversation
Oops, latest commit created (one) too many reflectivity data points. Don't push when tired...
Add docstrings to the break-out functions. Also add some type hints, give the non-user facing functions an underscore prefix, and revert the instance check to an instance check instead of an attribute check. (Neither is ugly, instance check is probably more robust)
Add some docstrings, and did some minor formatting tweaks to make it slightly more in-line with PEP8 regarding line-length. (I am personally targeting 79 characters (PEP default, but they explictly state that one can deviate if agreed upon), but we probably want to formaly decide this with a linter (e.g. Flake8)
Add unit tests for `fisher` function in `utils`
sstendahl
added a commit
to sstendahl/HOGBEN
that referenced
this pull request
Sep 6, 2023
Merge main into linting branch
sstendahl
added a commit
to sstendahl/HOGBEN
that referenced
this pull request
Sep 6, 2023
Merge main into linting branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.