Conversation
jfkcooper
approved these changes
Sep 4, 2023
Owner
jfkcooper
left a comment
There was a problem hiding this comment.
Just to check, if there is no iSLD, this behaves as it did before? I think it does but wanted to check
Collaborator
Author
I just double-checked, if you create a refnx sample without specifiying the iSLD, it sets it equal to zero on init. Same with refl1d samples and irho. So short answer, yes. It will just copy the zero value from the iSLD in refnx to the irho value in refl1d sample. In the old case, it would assign zero upon init. So the end-result is the same in the case of an unassigned iSLD. |
Owner
|
perfect, resolve the conflicts and merge :) |
sstendahl
added a commit
to sstendahl/HOGBEN
that referenced
this pull request
Sep 6, 2023
Add iSLD to converter functions
sstendahl
added a commit
to sstendahl/HOGBEN
that referenced
this pull request
Sep 6, 2023
Add iSLD to converter functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #68.
Adds the imaginary part of the SLD to the
to_refnxandto_refl1dfunctions, such that this component is properly transferred over as well. For the refnx syntax, see the docs: https://refnx.readthedocs.io/en/latest/refnx.reflect.html#refnx.reflect.SLDWhere the parameters have to be added as argument as a Parameter type:
In this particular case, refl1d syntax is actually pretty straightforward. These changes in this method have been tested with the unit tests in PR #69.