Merged
Conversation
jfkcooper
requested changes
Jul 26, 2023
Collaborator
Author
|
Should be OK now, the changes outside of the fisher function happened when I gave Pycharm permission to solve the PEP8 conflicts. They did stop my linter from complaining. |
This reverts commit 03fcea9.
jfkcooper
requested changes
Jul 27, 2023
Owner
jfkcooper
left a comment
jfkcooper
left a comment
There was a problem hiding this comment.
Sorry, a couple more comments!
sstendahl
pushed a commit
to sstendahl/HOGBEN
that referenced
this pull request
Sep 6, 2023
…rtance-scaling 56 Allow custom importance scaling
sstendahl
pushed a commit
to sstendahl/HOGBEN
that referenced
this pull request
Sep 6, 2023
…rtance-scaling 56 Allow custom importance scaling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #56.
Adds an optional argument to the
fisherfunction, allowing to scale the importance of each parameter with a predefined value, on top of the regular unit scaling. As per relevant paper