Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #1144 - Phase 2 : SIMD related concept + logical constraints #1307

Merged
merged 9 commits into from
Jun 5, 2022
Merged

Issue #1144 - Phase 2 : SIMD related concept + logical constraints #1307

merged 9 commits into from
Jun 5, 2022

Conversation

jfalcou
Copy link
Owner

@jfalcou jfalcou commented Jun 3, 2022

No description provided.

DenisYaroshevskiy
DenisYaroshevskiy reviewed Jun 3, 2022
View reviewed changes
Copy link
Collaborator

@DenisYaroshevskiy DenisYaroshevskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not wild about "simd" as a concept name.
Why not simd_value?

include/eve/concept/simd.hpp Outdated Show resolved Hide resolved
include/eve/concept/simd.hpp Outdated Show resolved Hide resolved
@jfalcou
Copy link
Owner Author

jfalcou commented Jun 4, 2022

I am not wild about "simd" as a concept name. Why not simd_value?

As per #1144 discussion and decision, simd_value will be used for something else.

On e potential solution is to rename scalar -> vectorizable and simd -> vectorized AFTER we changed all the other concepts.
We can keep simd for now as a transition phase.

@DenisYaroshevskiy
Copy link
Collaborator

Discussion called instance_of_wide arithmetic_simd_value.
ANd it called scalar_value arithmetic_scalar_value .

We never agreed on simd concept that's for sure.

@jfalcou jfalcou merged commit 37b31cc into main Jun 5, 2022
@jfalcou jfalcou deleted the fix-1144-2/concept-cleanup branch June 5, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisYaroshevskiy DenisYaroshevskiy DenisYaroshevskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfalcou @DenisYaroshevskiy