fix param self references, and additional self reference tests

pkg/specs/dependencies/dependencies.go

@@ -45,6 +45,7 @@ lookup:
 		// Remove any self references
 		if edge == node.Name {
 			delete(unresolved, edge)
+			delete(node.DependsOn, edge)
 			continue
 		}
 

pkg/specs/dependencies/dependencies_test.go

@@ -233,3 +233,37 @@ func TestCallCircularDependenciesDetection(t *testing.T) {
 		}
 	}
 }
+
+func TestSelfDependencyDetection(t *testing.T) {
+	flow := &specs.Flow{
+		Nodes: []*specs.Node{
+			{
+				Name: "first",
+				DependsOn: map[string]*specs.Node{
+					"first": nil,
+				},
+			},
+			{
+				Name: "second",
+				DependsOn: map[string]*specs.Node{
+					"second": nil,
+				},
+			},
+		},
+	}
+
+	tests := []*specs.Node{
+		flow.Nodes[0],
+	}
+
+	for _, input := range tests {
+		err := ResolveNode(flow, input, make(map[string]*specs.Node))
+		if err != nil {
+			t.Fatalf("unexpected error %s", err)
+		}
+
+		if len(input.DependsOn) > 0 {
+			t.Fatalf("unexpted remaining dependencies, expected dependencies to be empty: %+v", input.DependsOn)
+		}
+	}
+}

pkg/specs/dependencies/references.go

@@ -138,7 +138,8 @@ func ResolveParamReferences(params map[string]*specs.PropertyReference, dependen
 
 		resource, _ := lookup.ParseResource(param.Resource)
 		if resource != template.StackResource && resource != template.InputResource {
-			dependencies[template.SplitPath(param.Resource)[0]] = nil
+			dependency := template.SplitPath(param.Resource)[0]
+			dependencies[dependency] = nil
 		}
 
 		clone := CloneProperty(param.Property, param, key, key)

pkg/transport/references.go

@@ -20,7 +20,10 @@ func DefineCaller(ctx instance.Context, node *specs.Node, manifest *specs.FlowsM
 		}
 
 		dependencies.ResolvePropertyReferences(prop, node.DependsOn)
-		dependencies.ResolveNode(manager, node, node.DependsOn)
+		err = dependencies.ResolveNode(manager, node, make(map[string]*specs.Node))
+		if err != nil {
+			return err
+		}
 	}
 
 	return nil