Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - autoDismiss, dismiss the permissionView even by clicking on our of multiple items #93

Closed
gharary opened this issue Jul 29, 2021 · 4 comments
Labels
possible bug Something isn't working

Comments

@gharary
Copy link

gharary commented Jul 29, 2021

Describe the bug
A clear and concise description of what the bug is.

I have a JMModal with 3 permissions [Health, Motion, Notification].

By clicking any of them, with autoDismiss set to true, the view disappears without waiting for other permissions to be set.

Here is my code:

.JMModal(showModal: $showPermission, for: [.health(categories: .init(read:readData)),.notification,.motion],
autoDismiss: true,
autoCheckAuthorization: true,
restrictDismissal: true)

Expected behavior
disabling autoDismiss keeps the view open until manually dismiss it.

Desktop (please complete the following information):

  • OS: [e.g. iOS] 14.5
  • Version [e.g. 22] 1.5.2
@gharary gharary added the possible bug Something isn't working label Jul 29, 2021
@jevonmao
Copy link
Owner

Ok let me investigate this.

@jevonmao
Copy link
Owner

jevonmao commented Aug 4, 2021

Need a few more days, on trip right now.

jevonmao added a commit that referenced this issue Aug 9, 2021
jevonmao added a commit that referenced this issue Aug 9, 2021
@jevonmao
Copy link
Owner

jevonmao commented Aug 9, 2021

@gharary Try v1.5.3 and let me know if it's fixed.

@gharary
Copy link
Author

gharary commented Aug 10, 2021

Problem solved. Thanks

@gharary gharary closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possible bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants