Jetty 12.0.x ee9 serverpush tck #9902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee9-serverpush-tck
Before, the EOF frame was not added to the HTTP2Stream queue. When the pushed request was completing it tried to consume the available content, but it was not finding EOF and so was emitting a reset frame, causing the TCK failure. Now the EOF frame is always added to the HTTP2Stream queue, so it is properly consumed when completing the pushed request. Signed-off-by: Simone Bordet <[email protected]>
janbartel
added
Bug
|
good fix for TCK (tested locally and it looks you tested on CI as well) |
|
@lorban could you take a look at this? Simone has made a relatively simple change in |
Signed-off-by: Ludovic Orban <[email protected]>
|
Committed a change to fix H2 trailers that the H2 push fix broke. |
olamy
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the remaining ee9 serverpush tck errors as per #9760