Various improvements to CyclicTimeouts. #9897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sbordet
commented
Jun 10, 2023
sbordet
commented
- Improved reset of the earliest timeout before iteration.
- Removed check for getExpireNanoTime() == -1, since it's a valid value.
- When onExpired(Expirable) returns false, the Expirable should arrange to move its timeout in the future.
* Improved reset of the earliest timeout before iteration. * Removed check for getExpireNanoTime() == -1, since it's a valid value. * When onExpired(Expirable) returns false, the Expirable should arrange to move its timeout in the future. Signed-off-by: Simone Bordet <[email protected]>
gregw
approved these changes
Jun 10, 2023
sbordet
added a commit
that referenced
this pull request
Feb 5, 2024
…en a server times out Fixed regression introduced with #9897. After onExpire() returns false, the entity is asked again the expirationNanoTime, but there was no check whether it was Long.MAX_VALUE, indicating that the entity should not be rescheduled. This was causing scheduling of timeouts far in the future (about Long.MAX_VALUE nanos away), but each at a slightly different time, causing the leak. Signed-off-by: Simone Bordet <[email protected]>
sbordet
added a commit
that referenced
this pull request
Feb 5, 2024
…en a server times out Fixed regression introduced with #9897. After onExpire() returns false, the entity is asked again the expirationNanoTime, but there was no check whether it was Long.MAX_VALUE, indicating that the entity should not be rescheduled. This was causing scheduling of timeouts far in the future (about Long.MAX_VALUE nanos away), but each at a slightly different time, causing the leak. Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.