Refine HttpChannel.Listener #9872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better comments split write into two cheaper events
Only slice the buffer if a non default listener
joakime
reviewed
Jun 5, 2023
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/HttpChannelListeners.java
Outdated
Show resolved
Hide resolved
Used a boolean instead of a constant MethodHandle
sbordet
requested changes
Jun 6, 2023
Comment on lines
+134
to
+135
| * Invoked just after the HTTP request line and headers have been parsed | ||
| * (i.e. from within the call to {@link HttpChannel#onRequest(MetaData.Request)}). |
| * </p> | ||
| * | ||
| * @param request the request object | ||
| * @param request the request object. The {@code read()} and {@code demand(Runnable)} methods must not be called by the listener. |
There was a problem hiding this comment.
I think calling read() and demand() should not be a worry -- if called wrongly it's the user fault.
sbordet
reviewed
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addendum to #9754
better comments
split write into two cheaper events