Jetty 12 simplify EchoHandler #9783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
May 17, 2023
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpField.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpFields.java
Outdated
Show resolved
Hide resolved
| case TRAILER -> response.setTrailersSupplier(HttpFields.build()); | ||
| case TRANSFER_ENCODING -> contentLength = Long.MAX_VALUE; | ||
| } | ||
| } |
There was a problem hiding this comment.
Quite harder to read, because now different concerns are in the same code blob.
-0 but I won't oppose too much.
There was a problem hiding this comment.
wow I find it so much easier to read as each concern is now only 1 or 2 lines and not spread over multiple blocks of code.
sbordet
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify EchoHandler to make it a better example Handler.