Fixes to QPACK configuration from SETTINGS frames. #9728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
* Improved configuration upon sending/receiving SETTINGS frames. * Improved handling of blocked frames in HTTP3StreamConnection. Signed-off-by: Simone Bordet <[email protected]>
* Improved configuration upon sending/receiving SETTINGS frames. * Improved handling of blocked frames in HTTP3StreamConnection. * Fixed locking and reentrance in QPACK encoder/decoder. Signed-off-by: Simone Bordet <[email protected]>
lachlan-roberts
commented
May 15, 2023
...3/http3-server/src/main/java/org/eclipse/jetty/http3/server/internal/ServerHTTP3Session.java
Outdated
Show resolved
Hide resolved
...3/http3-server/src/main/java/org/eclipse/jetty/http3/server/internal/ServerHTTP3Session.java
Show resolved
Hide resolved
jetty-http3/http3-qpack/src/main/java/org/eclipse/jetty/http3/qpack/QpackEncoder.java
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <[email protected]>
|
@sbordet looks good to me, but I can't review with GitHub because it is my PR. Also the |
The instruction handler only writes to the encoder stream (does not call any user code), so we should be good. |
sbordet
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.