Issue #9464 - Add optional configuration to log user out after OpenID idToken expires. (Jetty-10) #9528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
If respectIdTokenExpiry is true always attempt re-authentication if idToken expires even for non-mandatory requests. Signed-off-by: Lachlan Roberts <[email protected]>
gregw
reviewed
Mar 23, 2023
jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdAuthenticator.java
Outdated
Show resolved
Hide resolved
jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdAuthenticator.java
Show resolved
Hide resolved
jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdAuthenticator.java
Show resolved
Hide resolved
sbordet
requested changes
Mar 23, 2023
There was a problem hiding this comment.
@lachlan-roberts I have concerns about this change. Let's discuss them when possible.
jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdCredentials.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
travisspencer
previously approved these changes
Mar 28, 2023
jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdAuthenticator.java
Show resolved
Hide resolved
sbordet
requested changes
Mar 28, 2023
jetty-openid/src/test/java/org/eclipse/jetty/security/openid/OpenIdProvider.java
Show resolved
Hide resolved
jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdCredentials.java
Outdated
Show resolved
Hide resolved
jetty-openid/src/test/java/org/eclipse/jetty/security/openid/OpenIdProvider.java
Outdated
Show resolved
Hide resolved
jetty-openid/src/test/java/org/eclipse/jetty/security/openid/OpenIdProvider.java
Outdated
Show resolved
Hide resolved
jetty-openid/src/test/java/org/eclipse/jetty/security/openid/OpenIdProvider.java
Outdated
Show resolved
Hide resolved
jetty-openid/src/test/java/org/eclipse/jetty/security/openid/OpenIdProvider.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| loggedInUsers.decrement(); | ||
| resp.setContentType("text/plain"); | ||
| resp.sendRedirect(logoutRedirect); |
Check warning
Code scanning / CodeQL
URL redirection from remote source
There was a problem hiding this comment.
This was dismissed, as this was a test case
sbordet
approved these changes
Mar 29, 2023
|
Will wait until the jetty-security changes in jetty-12 are done before I merge this, as the OpenID code will be moved to jetty-core. (see #9405) |
gregw
added
the
Sponsored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9464
Add new configuration parameter called
respectIdTokenExpirywhich if set to true will log the user out after the idToken has expired and attempt to redirect back to the OpenID provider to be re-authenticated.