Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename process to handle #9385

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Rename process to handle #9385

merged 4 commits into from
Feb 16, 2023

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Feb 16, 2023

  • Request.Processor to Request.Handler
  • Handler.process to Handler.handle

@gregw
Rename process to handle
dcd6ddc 
 + Request.Processor to Request.Handler
 + Handler.process to Handler.handle
@gregw gregw requested review from sbordet and lorban and removed request for sbordet February 16, 2023 09:00
@sbordet
Removed Request.__defaultLocale, it was only used internally.
02c53a6 
More renamings from *process to *handler for variables, methods, test methods, comments, etc.

Signed-off-by: Simone Bordet <[email protected]>
lorban
lorban requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a few renames.

We now have Handler and Request.Handler which adds a bit of confusion, but despite that I like this better.

...-ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/WebXmlConfiguration.java Show resolved Hide resolved
...e10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletRequestState.java Outdated Show resolved Hide resolved
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/ServletChannel.java Outdated Show resolved Hide resolved
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/handler/DelayedHandlerTest.java Outdated Show resolved Hide resolved
jetty-core/jetty-server/src/test/java/org/eclipse/jetty/server/HttpChannelTest.java Outdated Show resolved Hide resolved
jetty-core/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/Rule.java Show resolved Hide resolved
jetty-core/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/Rule.java Show resolved Hide resolved
jetty-core/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/RegexRule.java Show resolved Hide resolved
jetty-core/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/PatternRule.java Show resolved Hide resolved
jetty-core/jetty-rewrite/src/main/java/org/eclipse/jetty/rewrite/handler/HeaderRule.java Show resolved Hide resolved
@sbordet
Reverted old-style, obsolete, horrible, soon-to-be-removed (hopefully…
7a649cc 
…), almost never used, wrongly named because it's a list and should be plural, `__defaultLocale` field.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
More renaming of methods/variables/comments from process to handle.
bc6ba38 
Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet merged commit 0ca6295 into jetty-12.0.x Feb 16, 2023
@sbordet sbordet deleted the jetty-12-rename-process-to-handle branch February 16, 2023 17:21
gregpoulos pushed a commit to gregpoulos/jetty.project that referenced this pull request Feb 16, 2023
Merge branch 'jetty-12.0.x' of https://github.com/eclipse/jetty.project…
1ca6761 
… into jetty-12.0.x-old-docs-remove-logging-sections

* 'jetty-12.0.x' of https://github.com/eclipse/jetty.project:
  Rename process to handle (jetty#9385)
  Bump maven-deploy-plugin from 3.0.0 to 3.1.0
  Bump asciidoctorj-diagram from 2.2.3 to 2.2.4
  Bump jakarta.servlet.jsp-api from 3.0.0 to 3.1.1
  Bump maven-invoker-plugin from 3.4.0 to 3.5.0
  Bump maven.surefire.plugin.version from 3.0.0-M8 to 3.0.0-M9
  Bump maven-javadoc-plugin from 3.4.1 to 3.5.0
  Bump tycho-p2-repository-plugin from 3.0.1 to 3.0.2
  Bump maven.version from 3.8.7 to 3.9.0
  Remove jetty-ant (jetty#9382)
  Added inceptionDates.csv
  Issue jetty#9336 - remember ContentSources to fail from ChunksPart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorban lorban lorban approved these changes

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregw @sbordet @lorban