Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Unsafe Host Header Behaviors #9283

Merged
merged 9 commits into from
Feb 3, 2023
Merged

Configurable Unsafe Host Header Behaviors #9283

merged 9 commits into from
Feb 3, 2023

Commits on Feb 1, 2023

  1. Adding HttpCompliance.DUPLICATE_HOST_HEADERS 

    + Optional compliance that allowance
  duplicate host headers.

Signed-off-by: Joakim Erdfelt <[email protected]>
    @joakime
    joakime committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3129163 View commit details
    Browse the repository at this point in the history

  2. Adding HttpCompliance.UNSAFE_HOST_HEADER 

    + Optional compliance that allows
  unsafe host headers.

Signed-off-by: Joakim Erdfelt <[email protected]>
    @joakime
    joakime committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e400ce8 View commit details
    Browse the repository at this point in the history

  3. Adding warning logging for bad Host / authority situations 

    Signed-off-by: Joakim Erdfelt <[email protected]>
    @joakime
    joakime committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    849a097 View commit details
    Browse the repository at this point in the history

  4. Fixing checkstyle violation

    @joakime
    joakime committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    2ac0652 View commit details
    Browse the repository at this point in the history

  5. Fixing HttpParserTest.testDuplicateHostAllow 

    Signed-off-by: Joakim Erdfelt <[email protected]>
    @joakime
    joakime committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7907d89 View commit details
    Browse the repository at this point in the history

  6. Updates from review 

    Signed-off-by: Joakim Erdfelt <[email protected]>
    @joakime
    joakime committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    98a7268 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Reworked HostPort.unsafe() handling and test cases per review 

    Signed-off-by: Joakim Erdfelt <[email protected]>
    @joakime
    joakime committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    de72f2f View commit details
    Browse the repository at this point in the history

  2. Clean up implementation 

    Signed-off-by: Joakim Erdfelt <[email protected]>
    @joakime
    joakime committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    58c2573 View commit details
    Browse the repository at this point in the history

  3. Add more comments 

    Signed-off-by: Joakim Erdfelt <[email protected]>
    @joakime
    joakime committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1215dba View commit details
    Browse the repository at this point in the history