Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate osgi dependency declarations in top level pom #9230

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

janbartel
Copy link
Contributor

@janbartel janbartel commented Jan 31, 2023

Duplicate declarations of dependencies causes the following build warning:

> [INFO] Scanning for projects...
> [WARNING] 
> [WARNING] Some problems were encountered while building the effective model for org.eclipse.jetty.ee10:jetty-ee10-test-http2-webapp:war:12.0.0-SNAPSHOT
> [WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.osgi:osgi.annotation:jar -> version ${osgi-annotation-version} vs ${org.osgi.annotation.version} @ org.eclipse.jetty:jetty-project:12.0.0-SNAPSHOT, /home/janb/src/jetty-eclipse/jetty-12.0.x/pom.xml, line 1681, column 19
> [WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.osgi:org.osgi.util.promise:jar -> version ${osgi-util-promise-version} vs ${org.osgi.util.promise.version} @ org.eclipse.jetty:jetty-project:12.0.0-SNAPSHOT, /home/janb/src/jetty-eclipse/jetty-12.0.x/pom.xml, line 1691, column 19
> [WARNING] 
> [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
> [WARNING] 
> [WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
> 

@janbartel janbartel self-assigned this Jan 31, 2023
@janbartel janbartel requested a review from olamy January 31, 2023 04:29
@janbartel janbartel added Bug For general bugs on Jetty side Jetty 12 labels Jan 31, 2023
@joakime joakime merged commit bf57529 into jetty-12.0.x Jan 31, 2023
@joakime joakime deleted the jetty-12.0.x-fix-duplicate-osgi-deps branch January 31, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants