Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 12 - Add and allow plural form of existing start.jar args. #9202

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Jetty 12 - Add and allow plural form of existing start.jar args. #9202

merged 1 commit into from
Jan 24, 2023

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Jan 24, 2023

  • new --modules=<name>,<name>
  • new --libs=<classpath>
  • updated usage.txt
  • updated warning output hint

@joakime
Add and allow plural form of existing args.
8d1cccf 
+ new `--modules=<name>,<name>`
+ new `--libs=<classpath>`
+ updated usage.txt
+ updated warning output hint
@joakime joakime added this to the 12.0.x milestone Jan 24, 2023
@joakime joakime requested review from gregw and sbordet January 24, 2023 18:58
@joakime joakime self-assigned this Jan 24, 2023
gregw
gregw approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joakime joakime merged commit 7d8dd94 into jetty-12.0.x Jan 24, 2023
@joakime joakime deleted the fix/jetty-12.0.x/plural-args-in-startjar branch January 24, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@sbordet sbordet Awaiting requested review from sbordet

Assignees

@joakime joakime

Labels
None yet
Projects
None yet
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@joakime @gregw