Jetty 12 - Cleanup Shutdown classes #9201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
requested changes
Jan 24, 2023
| @@ -28,14 +28,14 @@ | |||
| /** | |||
| * Handler to track active requests and allow them to gracefully complete. | |||
| */ | |||
| public class GracefulShutdownHandler extends Handler.Wrapper implements Graceful | |||
There was a problem hiding this comment.
Do we have a module and xml to add this to a jetty-home? If not, we probably need one, if so, then it needs to have the rename.
There was a problem hiding this comment.
Not that I can find.
Let me add a module to this PR then.
joakime
commented
Jan 24, 2023
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ShutdownHandler.java
Outdated
Show resolved
Hide resolved
gregw
approved these changes
Jan 25, 2023
lorban
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShutdownHandlerin jetty-core (with test cases)ShutdownHandlerGracefulShutdownHandlerto justGracefulHandlerFixes #9200