Jetty 12 - Introduce GracefulShutdownHandler and Test

[joakime]

• started with removing @Disabled from GracefulStopTest.java

[gregw]

This still does not feel correct. If we are not started, then we should not be processing the request, even for a 503.

Suggested change

	// Increment the counter before the test for isShutdown(), to avoid race conditions.
	ShutdownTrackingCallback shutdownCallback = new ShutdownTrackingCallback(request, response, callback);
	Handler handler = getHandler();
	if (handler == null || !isStarted() || isShutdown())
	{
	if (LOG.isDebugEnabled())
	LOG.debug("Service Unavailable: {}", request.getHttpURI());
	Response.writeError(request, response, shutdownCallback, HttpStatus.SERVICE_UNAVAILABLE_503);
	return true;
	}
	Handler handler = getHandler();
	if (handler == null || !isStarted())
	return false;
	// Increment the counter before the test for isShutdown(), to avoid race conditions.
	ShutdownTrackingCallback shutdownCallback = new ShutdownTrackingCallback(request, response, callback);
	if (isShutdown())
	{
	if (LOG.isDebugEnabled())
	LOG.debug("Service Unavailable: {}", request.getHttpURI());
	Response.writeError(request, response, shutdownCallback, HttpStatus.SERVICE_UNAVAILABLE_503);
	return true;
	}

The handler==null case can be before or after.

[joakime]

Changed.

[joakime]

Before I dive into the jetty-start module for this ...

I'm wondering if this is the right name for this handler?
It doesn't provide GracefulShutdown, it manages the requests during graceful shutdown.
So how about GracefulRequestHandler instead?