Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latency recording utility handler #9172

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Jan 16, 2023

Add a small utility handler that standardizes the way latencies should be recorded.

Closes #8069.

@lorban lorban added this to the 12.0.x milestone Jan 16, 2023
@lorban lorban self-assigned this Jan 16, 2023
@lorban lorban requested review from sbordet, gregw and joakime January 16, 2023 11:41
@joakime
Copy link
Contributor

joakime commented Jan 16, 2023

Got an example of how it would be used?

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some niggles that you can fix if you like, otherwise good.

@lorban
Copy link
Contributor Author

lorban commented Jan 18, 2023

@joakime The fact that you made this comment means a test is needed, at least as some internal doc showing how this works. I've now added such test.

@lorban lorban force-pushed the jetty-12.0.x-8069-latency-recording-handler branch from 1cd5831 to 451ead8 Compare January 18, 2023 11:58
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban force-pushed the jetty-12.0.x-8069-latency-recording-handler branch from 451ead8 to 4977f7d Compare January 18, 2023 11:59
@lorban lorban requested a review from gregw January 18, 2023 11:59
@lorban lorban force-pushed the jetty-12.0.x-8069-latency-recording-handler branch from 4977f7d to be93d13 Compare January 18, 2023 12:40
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's better!

@lorban lorban merged commit f3c2294 into jetty-12.0.x Jan 19, 2023
@lorban lorban deleted the jetty-12.0.x-8069-latency-recording-handler branch January 19, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants