Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12.0.x 9131 remove path watcher #9158

Merged
merged 6 commits into from
Jan 19, 2023

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Jan 12, 2023

For #9131 remove the PathWatcher class and revert to Scanner usage.

@gregw gregw marked this pull request as ready for review January 13, 2023 00:01
@gregw gregw requested review from joakime and lorban January 13, 2023 00:02
@joakime joakime removed their request for review January 18, 2023 23:48
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly javadoc and some nits.

@gregw gregw requested a review from lorban January 19, 2023 11:11
@gregw
Copy link
Contributor Author

gregw commented Jan 19, 2023

@lorban it is a bit messy as the history is that we had a scan interval, then removed it for the pathwatcher (that never worked reliably) and now we are putting back the scan interval. I think it best to live with some deprecated methods for a while.

@gregw gregw merged commit 99fdd21 into jetty-12.0.x Jan 19, 2023
@gregw gregw deleted the jetty-12.0.x-9131-removePathWatcher branch January 19, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants