Use method references instead of reflection in TypeUtil #9115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeUtil currently uses reflection to convert Strings to primitive/boxed basic types. This may not only be a performance problem, but it also prevents environments like GraalVM native-image to detect required methods without the help of an agent. Use method references (Boolean::valueOf, etc.) instead. Signed-off-by: Christian Kohlschütter <[email protected]>
sbordet
requested changes
Jan 1, 2023
|
|
||
| @FunctionalInterface | ||
| private interface ValueOfString<T> { |
There was a problem hiding this comment.
Can this just be Function<String, T>? It's all internal anyway, no need for another type.
There was a problem hiding this comment.
good idea; see commit below
... and use Function<String,Object> instead.
sbordet
approved these changes
Jan 2, 2023
|
Somehow this PR has an enforcer rule violation ???? I'll dig into this in the morning. |
|
@kohlschuetter can you merge from |
…peUtil-class2Value
joakime
approved these changes
Jan 2, 2023
|
Looking good, merging. |
|
@gregw should we backport this to Jetty 10.0.x? |
joakime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeUtil currently uses reflection to convert Strings to primitive/boxed basic types.
This may not only be a performance problem, but it also prevents environments like GraalVM native-image to detect required methods without the help of an agent.
Use method references (Boolean::valueOf, etc.) instead.