Simpler TreeTrie.isEmpty() method #9075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid creating (Key)Set to just test for empty.
gregw
approved these changes
Dec 20, 2022
Comment on lines
279
to
303
| return !hasAnyKey(_root); | ||
| } | ||
|
|
||
| private boolean hasAnyKey(Node<V> t) | ||
| { | ||
| if (t != null) | ||
| { | ||
| if (t._key != null) | ||
| return true; | ||
|
|
||
| for (int i = 0; i < INDEX; i++) | ||
| { | ||
| if (t._nextIndex[i] != null) | ||
| { | ||
| if (hasAnyKey(t._nextIndex[i])) | ||
| return true; | ||
| } | ||
| } | ||
| for (int i = t._nextOther.size(); i-- > 0; ) | ||
| { | ||
| if (hasAnyKey(t._nextOther.get(i))) | ||
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
probably invert the boolean and rename isEmpty(Node)
There was a problem hiding this comment.
Inverted / Renamed
lorban
approved these changes
Dec 21, 2022
| if (t._key != null) | ||
| return false; | ||
|
|
||
| for (int i = 0; i < INDEX; i++) |
There was a problem hiding this comment.
Is there some test coverage for this logic?
There was a problem hiding this comment.
Yup, the first loop is 100% covered by the 2 new test cases.
The second loop executes, but nothing can trigger the internal isEmpty() logic with the test cases as it stands.
…0.x/treetrie-isempty-redux
|
I just pushed 3d4bb49 which slightly improves the test coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid creating (Key)Set to just test for empty.