Jetty 12.0.x osgi #9068
Merged
Jetty 12.0.x osgi #9068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ay! it's green! Can we merge this now? |
|
Oh please God can we????!! Somebody review this. |
|
@olamy please make this review a priority. |
olamy
approved these changes
Dec 21, 2022
| <spifly.version>1.3.4</spifly.version> | ||
| <!-- TODO --> | ||
| <skipTests>true</skipTests> | ||
| <spifly.version>1.3.6</spifly.version> |
There was a problem hiding this comment.
this version is repeated so many times maybe a single place would be better?
| </dependency> | ||
| <dependency> | ||
| <groupId>org.osgi</groupId> | ||
| <artifactId>org.osgi.service.component</artifactId> |
There was a problem hiding this comment.
this and some other repeated would be better in dptMngt in top pom and added here without version (to have a single place with the version and dptMngt is a better way to handle transitivity and possible upper bound issues)
There was a problem hiding this comment.
Lets tackle this as a clean PR in a followup PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make osgi work with jetty-12 environments.