Enable all jetty-deploy tests #9058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
commented
Dec 15, 2022
| } | ||
| } | ||
|
|
||
| public void loadPropertiesFromString(String path) throws IOException |
There was a problem hiding this comment.
These 3 replace the old org.eclipse.jetty.deploy.PropertiesConfigurationManager functionality (that was removed in Jetty 12)
You can see how this is used from an XML configuration below in the src/test/resources/jetty-deploymgr-contexts.xml file
joakime
commented
Dec 15, 2022
| @@ -76,7 +76,7 @@ public void pathChanged(Path path) throws Exception | |||
| @Override | |||
| public void pathRemoved(Path path) throws Exception | |||
| { | |||
| ScanningAppProvider.this.pathChanged(path); | |||
| ScanningAppProvider.this.pathRemoved(path); | |||
There was a problem hiding this comment.
Look at that, a legit bug enabling the tests revealed.
janbartel
approved these changes
Dec 19, 2022
…0.x/deploy-test-updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling all jetty-deploy tests.
Cleaning up tests for modern techniques.
Removing test resources that are no longer being used. (most moved to the ee specific tests)