response#getWriter should throw UnsupportedEncodingException in case of bad character encoding used #9037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCK issue
According to TCK and servlet api this should throws
UnsupportedEncodingException
but actually EncodingHttpWriter catch it then wrap it in new RuntimeException
@gregw I was not sure how to fix that.
I would have preferred to change the constructor (to avoid such
catch
andinstanceof
blockpublic EncodingHttpWriter(HttpOutput out, String encoding)
to
public EncodingHttpWriter(HttpOutput out, String encoding) throws IOException
Signed-off-by: Olivier Lamy [email protected]