Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #8678 - Jetty client receives GO_AWAY and continue to send traffic on same connection #8891

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Fixes #8678 - Jetty client receives GO_AWAY and continue to send traffic on same connection #8891

merged 3 commits into from
Nov 14, 2022

Commits on Nov 12, 2022

  1. Fixes #8678 - Jetty client receives GO_AWAY and continue to send traf… 

    …fic on same connection

* Now upon receiving the GOAWAY, the connection is removed from the pool, so it cannot be used by new requests.
* HTTP2Session.removeStream() now happens _after_ notifying HEADERS and DATA events, although the Stream state change still happens before.
This is necessary to avoid that a "close" event is notified before a "headers" or "data" event.

With these changes, the race window of a client acquiring a connection while the server is closing it is reduced, but it is impossible to close it completely.

Signed-off-by: Simone Bordet <[email protected]>
    @sbordet
    sbordet committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    fbc23ac View commit details
    Browse the repository at this point in the history

  2. Updated copyright. 

    Signed-off-by: Simone Bordet <[email protected]>
    @sbordet
    sbordet committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    184547a View commit details
    Browse the repository at this point in the history

  3. Fixed flaky test. 

    Signed-off-by: Simone Bordet <[email protected]>
    @sbordet
    sbordet committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    9a74b60 View commit details
    Browse the repository at this point in the history