Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump slf4j to 2.0.0-beta1 and logback to 1.3.0-beta0 #8467

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Aug 15, 2022

Signed-off-by: Joakim Erdfelt [email protected]

@joakime joakime added the dependencies Pull requests that update a dependency file label Aug 15, 2022
@joakime joakime requested a review from olamy August 15, 2022 22:22
@joakime joakime self-assigned this Aug 15, 2022
@joakime
Copy link
Contributor Author

joakime commented Aug 15, 2022

@olamy this is for jetty-10.0.x branch. Just getting ahead of the normal dependabot, as I'd like to make sure the logging is happy early.

@olamy
Copy link
Member

olamy commented Aug 16, 2022

error is

2022-08-16 04:51:37.280:INFO :oejtd.JettyHomeTester:ConsoleStreamer/STDERR: INFO  : download https://repo1.maven.org/maven2/org/slf4j/slf4j-log4j12/2.0.0-beta1/slf4j-log4j12-2.0.0-beta1.jar to /home/jenkins/agent/workspace/jetty.project_PR-8467/.repository/org/slf4j/slf4j-log4j12/2.0.0-beta1/slf4j-log4j12-2.0.0-beta1.jar
2022-08-16 04:51:37.719:INFO :oejtd.JettyHomeTester:ConsoleStreamer/STDERR: java.io.IOException: URL GET Failure [404/Not Found] on https://repo1.maven.org/maven2/org/slf4j/slf4j-log4j12/2.0.0-beta1/slf4j-log4j12-2.0.0-beta1.jar

because of https://repo1.maven.org/maven2/org/slf4j/slf4j-log4j12/2.0.0-beta1/slf4j-log4j12-2.0.0-beta1.pom

<relocation>
  <groupId>org.slf4j</groupId>
  <artifactId>slf4j-reload4j</artifactId>
  <version>2.0.0-beta1</version>
</relocation>

our maven download tooling do not support relocation ;)

@joakime joakime merged commit 3157256 into jetty-10.0.x Aug 16, 2022
@joakime joakime deleted the fix/jetty-10-upgrade-slf4j branch August 16, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants