Fix #8294 push added cookie #8298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reparse cookie added with addCookie Signed-off-by: Greg Wilkins <[email protected]>
joakime
reviewed
Jul 13, 2022
jetty-server/src/test/java/org/eclipse/jetty/server/RequestTest.java
Outdated
Show resolved
Hide resolved
joakime
requested changes
Jul 13, 2022
Added extra test to ensure maxAge is being parsed Signed-off-by: Greg Wilkins <[email protected]>
Added extra test to ensure maxAge is being parsed with other cookie attributes Signed-off-by: Greg Wilkins <[email protected]>
joakime
approved these changes
Jul 14, 2022
|
@joakime can you merge for me and then merge through 11 & 12. |
|
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reparse cookie added with addCookie via the
java.net.HttpCookiefor #8294Signed-off-by: Greg Wilkins [email protected]