Issue #7632 Make osgi build work with snapshot jsp jars #7633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <[email protected]>
|
Interesting. Does this just create a new maven property for use in the manifest? |
joakime
approved these changes
Feb 21, 2022
olamy
approved these changes
Feb 22, 2022
|
@joakime it creates a property, which you can use just in the maven build, or you can use it to affect how you generate the manifest. In this case we're using it to set the minimum version of packages in generated manifest. It essentially just lops off any "-SNAPSHOT" from the maven version property, which isn't valid for osgi. |
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7632