Issue #7414 Deprecate QoSFilter setters #7506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <[email protected]>
gregw
requested changes
Feb 7, 2022
| @@ -293,7 +293,9 @@ public long getWaitMs() | |||
| * for the semaphore to become available before suspending a request. | |||
| * | |||
| * @param value wait time (in milliseconds) | |||
| * @deprecated do not use | |||
There was a problem hiding this comment.
Should we say use init parameters instead?
gregw
approved these changes
Feb 7, 2022
22 tasks
joakime
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Issue #7414 Deprecate QoSFilter setters Signed-off-by: Jan Bartel <[email protected]> (cherry picked from commit c742c2e)
This was referenced Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7414
The OP reported that calling
QoSFilter.setMaxRequests(int)throws NPE. This is because it uses a field that is only initialized afterinit()is called. The filter seems to expect that values are set viainit-params, not via setters. Certainly there is no code that would handle one of the setters being called whilst the filter is in service. The best way forward seems to be to eventually remove those setters, after beingdeprecated.