Fix #6883 relative welcome redirect #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #6883 relative welcome redirect + make all redirects able to be relative + added test for relative redirection in ResourceService Signed-off-by: Greg Wilkins <[email protected]>
|
@gregw the new tests do not seem to test the original issue. I locally reverted the changes to |
|
@lachlan-roberts good catch. There is a bug in |
Fix the HttpFieldsContainsHeaderValue impl Signed-off-by: Greg Wilkins <[email protected]>
|
@lachlan-roberts I've pushed a fix for that, but there is a good chance it might break some other tests that were relying on the wrong behavior |
gregw
commented
Sep 22, 2021
jetty-http/src/test/java/org/eclipse/jetty/http/matchers/HttpFieldsContainsHeaderValue.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Greg Wilkins <[email protected]>
…83-relative-welcome-redirect
Signed-off-by: Greg Wilkins <[email protected]>
joakime
approved these changes
Sep 22, 2021
gregw
added a commit
that referenced
this pull request
Sep 22, 2021
Fix #6883 relative welcome redirect + make all redirects able to be relative + added test for relative redirection in ResourceService Signed-off-by: Greg Wilkins <[email protected]>
gregw
added a commit
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6883 relative welcome redirect
Signed-off-by: Greg Wilkins [email protected]